feat: addon tests and some variable changes in catalog.json #47
Conversation
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
/run pipeline |
|
Build has failed 3 times so far. 2 times it failed because I set |
|
/run pipeline |
2 similar comments
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
Bump to latest test wrapper version too |
|
/run pipeline |
tests/pr_test.go
Outdated
| map[string]interface{}{ | ||
| "region": "eu-de", | ||
| "prefix": options.Prefix, | ||
| "secrets_manager_service_plan": "trial", |
There was a problem hiding this comment.
not technically needed as
a) there is a default value for the virtual input
b) we never use it as we override the plan to null when using existing instance in code below
I wont hold up the PR for this change though - if it goes green Ill merge. If not, we can maybe fix and re-run pipeline
|
/run pipeline |
|
cluster is built but it stays in warning state, checked with valerio and he created a debug pod from which any external urls are not accessible, although public gateways are attached and outbound traffic is allowed. Debugging on the issue currently. |
2 participants
Description
Added Addon test and few virtual variables have been exposed in ibm_catalog.json for openshift cluster
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Following variable has been renamed in DA
ocp_version -> openshift_version
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers